Add Public IP Search Function #2

2022-08-26T17:43:12-04:00

sriramsv commented

2022-08-26 17:43:12 -04:00

(Migrated from github.com)

Add ability to get public IP by search function

This is useful as sometimes we just want to copy the Public IP for some use cases and not really intend to have it as a widget on the home screen

Add ability to get public IP by search function This is useful as sometimes we just want to copy the Public IP for some use cases and not really intend to have it as a widget on the home screen

zobnin commented

2022-08-27 00:18:45 -04:00

(Migrated from github.com)

Good script, thank you. Would you just make two corrections for consistency:

The name of the search scripts is displayed as a title in the search results, so the word "search" at the end would be superfluous.
When matching strings, it's better not to just look for "ip" in search string, but to look for "^ip$" pattern, so script will react only to "ip" and not to "script" or "iphone".

Good script, thank you. Would you just make two corrections for consistency: 1. The name of the search scripts is displayed as a title in the search results, so the word "search" at the end would be superfluous. 2. When matching strings, it's better not to just look for "ip" in search string, but to look for "^ip$" pattern, so script will react only to "ip" and not to "script" or "iphone".

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: unstableKitsune/aiolauncher_scripts#2